Add static address to quickstart examples #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
=======================================
Coverage 74.98% 74.98%
=======================================
Files 80 80
Lines 15531 15531
Branches 1489 1489
=======================================
Hits 11646 11646
Misses 3849 3849
Partials 36 36 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
danielpeintner
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I am okay with the change even though I think this is not ideal for quickstart examples.
Can we come up with a better/other solution?
Is the issue gone in a dockerized setup? IF so, we should keep track of this issue to revert this change once docker is setup...
|
In theory here, designing the examples using node-wot cli would have helped, but given the time constraints, we opted for this quick solution. After tpac we should review the examples and understand what we would like to show to newcomers and how. |
relu91
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deployed Thingshttp://plugfest.thingweb.io:8081/coffee-machine have wrong href due to automatic ip address detection. This fixes it.
With @relu91 we have discussed offline and we should simply move to a dockerized setup to manage all Things and their environment variables (like IP address, port etc.).